-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update and expand /client
tests
#1169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is great. This is a ton of coverage.
It isn't in the scope for this PR because so much is already happening here and this lays a great foundation but I just want to make a note about adding more multistep, multicomponent interactions to some of the pages in the future. These kinds of tests become more important with snapshot testing checking basic things like content rendered and links etc. This frees us up to do more user-workflow imitation. For example, the Data Management page could test something like:
- Advance to Recommend
- Verifyy content of confirmation modal
- Confirm with modal
- Check updated content in row
You are doing some testing like this, especially in the TestRun view. I am down to merge as-is since this PR is a major accomplishment. This note is more of a message for both of us to keep an eye out for opportunities for user-workflow testing and as we add more of that, and snapshot testing solidifies, we might consider scaling back some of the content and link testing.
/client
tests/client
tests
This is a supporting PR for #1147 as well for expanding the current
/client
test suites. Changes here will contain a subset of of #1147.