Decompose and organize import-tests script
#1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
reviewed
Jul 22, 2024
| /** | ||
| * Strategies for different test format versions. | ||
| */ | ||
| const testFormatStrategies = { |
howard-e
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
@stalgiag this looks good to me!
DB construction that at least one of the tests would surface an errant change in functionality. If this is not the case, and there is room for this to introduce breaking changes
Yep a test should exist to confirm the state of the TestPlanVersion rows is the same before and after an import.
The other tests not breaking still serve as an indicator that all should be well given they're built around the import script but an explicit test like above should be done. It can be done in this PR or in another, I don't think this has to be blocked on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes and documents the code in the import-tests script. I tried to avoid changing functionality and only made minor code changes beyond breaking big functions up, grouping related functions into specific modules, and add JSDoc comments.
The database builds and the tests pass. I assume that this script is so foundational to DB construction that at least one of the tests would surface an errant change in functionality. If this is not the case, and there is room for this to introduce breaking changes, then I am okay with not merging out of an abundance of caution.
I also recognize that this reorganization is highly damaging to the git history. If we don't feel that the tradeoff in readability/maintainability is worth it then I would be happy to discard this PR.