Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove TestQueue v1 and update Test Queue e2e tests #1146

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Jul 8, 2024

This removes the original components/TestQueue and related components in favor of the updated Test Queue introduced in #1124.

This PR also updates and reorganizes tests related to the the original Test Queue and removes tests done using mocks and replaces them with e2e tests where appropriate.

@howard-e howard-e marked this pull request as ready for review July 8, 2024 21:13
@howard-e howard-e requested a review from stalgiag July 8, 2024 21:13
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually thoroughly with both mouse + screen and screenreader and didn't encounter any bugs. Nice job removing this. Also really excited about the extensive new end-to-end tests!

Small confirmation comment inline on something that seemed a bit out of place. Otherwise approved!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at main it seems that this was no longer used and this is clean up because it isn't likely to be used in the future? Adding this comment as a verification measure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! It was meant for a much older implementation of showing the test collection form before the <TestRenderer> was a thing. I was pretty surprised it was still there so using this as a chance to remove it.

@howard-e howard-e changed the title Remove TestQueue v1 feat: Remove TestQueue v1 and update Test Queue e2e tests Jul 10, 2024
@howard-e howard-e changed the title feat: Remove TestQueue v1 and update Test Queue e2e tests fix: Remove TestQueue v1 and update Test Queue e2e tests Jul 10, 2024
@howard-e howard-e merged commit fd6e86f into development Jul 10, 2024
2 checks passed
@howard-e howard-e deleted the remove-old-testqueue branch July 10, 2024 13:27
howard-e added a commit that referenced this pull request Jul 22, 2024
Includes the following changes:

**Features and Fixes**
* #1125 
* #1135
* #1144
* #1146
* #1150
* #1152
* #1153
* #1160

**Infrastructure changes**
* #969
* #1151
* #1148

---------

Co-authored-by: alflennik <[email protected]>
Co-authored-by: Mx Corey Frang <[email protected]>
Co-authored-by: cypress evelyn masso <[email protected]>
Co-authored-by: Stalgia Grigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants