fix: random key for each collection job #1135
Conversation
Squashed commit of the following: commit 12ae1e0 Author: Mx. Corey Frang <[email protected]> Date: Mon Jun 17 14:19:08 2024 -0400 got a little further, still blocked on tests commit d54ffad Author: Mx. Corey Frang <[email protected]> Date: Mon Jun 17 11:28:10 2024 -0400 debuggering commit 7bfa8f8 Author: Mx. Corey Frang <[email protected]> Date: Thu May 30 11:59:02 2024 -0400 turbo logging trying to track down a bug commit 842a459 Author: Mx. Corey Frang <[email protected]> Date: Wed May 29 12:21:15 2024 -0400 remove server abstraction layer
| .json({ error: `Could not find job with jobId: ${id}` }); | ||
|
|
||
| // store the collection job on the request to avoid a second lookup | ||
| req.collectionJob = job; |
There was a problem hiding this comment.
I was wondering how the collectionJob was going to get on the req when I looked at AutomationController before this. Thanks for the comment explainer
| }, | ||
| secret: { | ||
| type: DataTypes.UUID, | ||
| allowNull: false |
There was a problem hiding this comment.
Should we set defaultValue: uuid() here?
There was a problem hiding this comment.
that would lead to a single default uuid per time the app started up i think...
The beforeValidate hook was the most recommended and stable feeling suggestion I ran across for dealing with default values with uuid()
There was a problem hiding this comment.
Oh right that makes sense. Would Sequelize's UUIDV4 be useful here?
There was a problem hiding this comment.
I tried a few variants of the sequelize UUID stuff, the version I landed on was the one that made the "cleanest" sense of what was happening I believe
There was a problem hiding this comment.
Sounds good. Thanks for trying!
Co-authored-by: Howard Edwards <[email protected]>
Includes the following changes: **Features and Fixes** * #1125 * #1135 * #1144 * #1146 * #1150 * #1152 * #1153 * #1160 **Infrastructure changes** * #969 * #1151 * #1148 --------- Co-authored-by: alflennik <[email protected]> Co-authored-by: Mx Corey Frang <[email protected]> Co-authored-by: cypress evelyn masso <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]>
I think I finally got through most of the troubles I was having with this PR...
This removes the local "mock http server" for automation scheduler, as we aren't using that HTTP API to spawn jobs, just calling directly to github, we have a similar method to start a mock job to the one that starts the github job.
Each collectionJob now generates a unique UUID for it's
secretwhich is passed along to the job runner, and only usable for one collection job