Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AT version column to Test Queue #1098

Merged
merged 5 commits into from
May 20, 2024
Merged

Add AT version column to Test Queue #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c1f654
Add at version row to test queue
alflennik May 16, 2024
8cd698e
Fix client tests
alflennik May 16, 2024
074b644
Revert ats.json
howard-e May 20, 2024
80c9a26
Update column title
howard-e May 20, 2024
25dd91e
fix crash when assigning/unassigning
howard-e May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/components/TestQueue/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ const TestQueue = () => {
<thead>
<tr>
<th className="test-plan">Test Plan</th>
<th className="test-plan">AT Version Requirements</th>
<th className="testers">Testers</th>
<th className="report-status">Report Status</th>
<th className="actions">Actions</th>
Expand Down
16 changes: 16 additions & 0 deletions client/components/TestQueue/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ export const TEST_QUEUE_PAGE_QUERY = gql`
id
name
}
minimumAtVersion {
id
name
}
exactAtVersion {
id
name
}
browser {
id
name
Expand Down Expand Up @@ -108,6 +116,14 @@ export const TEST_PLAN_REPORT_QUERY = gql`
id
name
}
minimumAtVersion {
id
name
}
exactAtVersion {
id
name
}
browser {
id
name
Expand Down
7 changes: 6 additions & 1 deletion client/components/TestQueueRow/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const TestQueueRow = ({
testPlanRunId: run.id,
...run.tester
}))
.filter(tester => !isBot(tester));
.filter(tester => !tester.isBot);

const getTestPlanRunIdByUserId = userId => {
return draftTestPlanRuns.find(({ tester }) => tester.id === userId).id;
Expand Down Expand Up @@ -530,6 +530,11 @@ const TestQueueRow = ({
<LoadingStatus message={loadingMessage}>
<tr className="test-queue-run-row">
<th>{renderAssignedUserToTestPlan()}</th>
<td style={{ padding: '0.75rem' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do these inline styles but considering this is only temporary patch, it's fine!

{testPlanReport.minimumAtVersion
? `${testPlanReport.minimumAtVersion.name} or later`
: testPlanReport.exactAtVersion.name}
</td>
<td>
{isSignedIn && isTester && (
<div className="testers-wrapper">
Expand Down
6 changes: 6 additions & 0 deletions client/tests/__mocks__/GraphQLMocks/TestQueuePageAdminPopulatedMock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ export default testQueuePageQuery => [
runnableTestsLength: 17,
markedFinalAt: null,
at: { id: '1', name: 'JAWS' },
minimumAtVersion: { id: '1', name: '2024.3321.1' },
exactAtVersion: null,
browser: { id: '2', name: 'Chrome' },
testPlanVersion: {
id: '1',
Expand Down Expand Up @@ -266,6 +268,8 @@ export default testQueuePageQuery => [
runnableTestsLength: 17,
markedFinalAt: null,
at: { id: '3', name: 'VoiceOver for macOS' },
minimumAtVersion: { id: '3', name: '14.5' },
exactAtVersion: null,
browser: { id: '3', name: 'Safari' },
testPlanVersion: {
id: '1',
Expand Down Expand Up @@ -296,6 +300,8 @@ export default testQueuePageQuery => [
runnableTestsLength: 17,
markedFinalAt: null,
at: { id: '2', name: 'NVDA' },
minimumAtVersion: null,
exactAtVersion: { id: '2', name: '2024.2' },
browser: { id: '1', name: 'Firefox' },
testPlanVersion: {
id: '1',
Expand Down
6 changes: 6 additions & 0 deletions client/tests/__mocks__/GraphQLMocks/TestQueuePageTesterPopulatedMock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ export default testQueuePageQuery => [
id: '2',
name: 'NVDA'
},
minimumAtVersion: { id: '1', name: '2024.3321.1' },
exactAtVersion: null,
browser: {
id: '1',
name: 'Firefox'
Expand Down Expand Up @@ -287,6 +289,8 @@ export default testQueuePageQuery => [
id: '2',
name: 'JAWS'
},
minimumAtVersion: { id: '3', name: '14.5' },
exactAtVersion: null,
browser: {
id: '1',
name: 'Firefox'
Expand Down Expand Up @@ -325,6 +329,8 @@ export default testQueuePageQuery => [
id: '3',
name: 'VoiceOver for macOS'
},
minimumAtVersion: null,
exactAtVersion: { id: '2', name: '2024.2' },
browser: {
id: '1',
name: 'Firefox'
Expand Down
Loading
Loading