Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AT version column to Test Queue #1098

Merged
merged 5 commits into from
May 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add at version row to test queue
alflennik committed May 16, 2024
commit 3c1f6546e423a5eed47c5ea4594d084218ab7edb
1 change: 1 addition & 0 deletions client/components/TestQueue/index.jsx
Original file line number Diff line number Diff line change
@@ -102,6 +102,7 @@ const TestQueue = () => {
<thead>
<tr>
<th className="test-plan">Test Plan</th>
<th className="test-plan">AT Version</th>
Copy link
Contributor

@howard-e howard-e May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<th className="test-plan">AT Version</th>
<th className="test-plan">AT Version Requirements</th>

That language may be preferred.

<th className="testers">Testers</th>
<th className="report-status">Report Status</th>
<th className="actions">Actions</th>
8 changes: 8 additions & 0 deletions client/components/TestQueue/queries.js
Original file line number Diff line number Diff line change
@@ -57,6 +57,14 @@ export const TEST_QUEUE_PAGE_QUERY = gql`
id
name
}
minimumAtVersion {
id
name
}
exactAtVersion {
id
name
}
browser {
id
name
7 changes: 6 additions & 1 deletion client/components/TestQueueRow/index.jsx
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ const TestQueueRow = ({
testPlanRunId: run.id,
...run.tester
}))
.filter(tester => !isBot(tester));
.filter(tester => !tester.isBot);

const getTestPlanRunIdByUserId = userId => {
return draftTestPlanRuns.find(({ tester }) => tester.id === userId).id;
@@ -530,6 +530,11 @@ const TestQueueRow = ({
<LoadingStatus message={loadingMessage}>
<tr className="test-queue-run-row">
<th>{renderAssignedUserToTestPlan()}</th>
<td style={{ padding: '0.75rem' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do these inline styles but considering this is only temporary patch, it's fine!

{testPlanReport.minimumAtVersion
? `${testPlanReport.minimumAtVersion.name} or later`
: testPlanReport.exactAtVersion.name}
</td>
<td>
{isSignedIn && isTester && (
<div className="testers-wrapper">

Unchanged files with check annotations Beta

});
// TODO: Revise timeout with pageReady check
it.skip('renders Test Queue page instructions', async () => {

Check warning on line 57 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 57 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(element).toHaveTextContent('Loading');
});
it.skip('renders Test Queue page instructions', async () => {

Check warning on line 113 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 113 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(voiceOverElements.length).toEqual(0);
});
it.skip('renders add test plan modal on button click', async () => {

Check warning on line 213 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 213 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(element).toHaveTextContent('Loading');
});
it.skip('renders Test Queue page instructions', async () => {

Check warning on line 252 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 252 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(assignedTestsElements.length).toBeGreaterThanOrEqual(1);
});
it.skip('renders add test plan modal on button click', async () => {

Check warning on line 297 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 297 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
return wrapper;
};
describe.skip('render', () => {

Check warning on line 22 in client/tests/TestRun.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite

Check warning on line 22 in client/tests/TestRun.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite
describe('loading when there are no tests', () => {
let wrapper;
beforeEach(() => {
return wrapper;
};
describe.skip('render', () => {

Check warning on line 16 in client/tests/UserSettings.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite

Check warning on line 16 in client/tests/UserSettings.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite
describe('user is not signed in', () => {
let wrapper;
beforeEach(() => {