-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AT version column to Test Queue #1098
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ const TestQueueRow = ({ | |
testPlanRunId: run.id, | ||
...run.tester | ||
})) | ||
.filter(tester => !isBot(tester)); | ||
.filter(tester => !tester.isBot); | ||
|
||
const getTestPlanRunIdByUserId = userId => { | ||
return draftTestPlanRuns.find(({ tester }) => tester.id === userId).id; | ||
|
@@ -530,6 +530,11 @@ const TestQueueRow = ({ | |
<LoadingStatus message={loadingMessage}> | ||
<tr className="test-queue-run-row"> | ||
<th>{renderAssignedUserToTestPlan()}</th> | ||
<td style={{ padding: '0.75rem' }}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't do these inline styles but considering this is only temporary patch, it's fine! |
||
{testPlanReport.minimumAtVersion | ||
? `${testPlanReport.minimumAtVersion.name} or later` | ||
: testPlanReport.exactAtVersion.name} | ||
</td> | ||
<td> | ||
{isSignedIn && isTester && ( | ||
<div className="testers-wrapper"> | ||
|
Unchanged files with check annotations Beta
}); | ||
// TODO: Revise timeout with pageReady check | ||
it.skip('renders Test Queue page instructions', async () => { | ||
Check warning on line 57 in client/tests/TestQueue.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
// allow page time to load | ||
await waitFor(() => new Promise(res => setTimeout(res, 0))); | ||
expect(element).toHaveTextContent('Loading'); | ||
}); | ||
it.skip('renders Test Queue page instructions', async () => { | ||
Check warning on line 113 in client/tests/TestQueue.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
// allow page time to load | ||
await waitFor(() => new Promise(res => setTimeout(res, 0))); | ||
expect(voiceOverElements.length).toEqual(0); | ||
}); | ||
it.skip('renders add test plan modal on button click', async () => { | ||
Check warning on line 213 in client/tests/TestQueue.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
// allow page time to load | ||
await waitFor(() => new Promise(res => setTimeout(res, 0))); | ||
expect(element).toHaveTextContent('Loading'); | ||
}); | ||
it.skip('renders Test Queue page instructions', async () => { | ||
Check warning on line 252 in client/tests/TestQueue.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
// allow page time to load | ||
await waitFor(() => new Promise(res => setTimeout(res, 0))); | ||
expect(assignedTestsElements.length).toBeGreaterThanOrEqual(1); | ||
}); | ||
it.skip('renders add test plan modal on button click', async () => { | ||
Check warning on line 297 in client/tests/TestQueue.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
// allow page time to load | ||
await waitFor(() => new Promise(res => setTimeout(res, 0))); | ||
return wrapper; | ||
}; | ||
describe.skip('render', () => { | ||
Check warning on line 22 in client/tests/TestRun.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
describe('loading when there are no tests', () => { | ||
let wrapper; | ||
beforeEach(() => { |
return wrapper; | ||
}; | ||
describe.skip('render', () => { | ||
Check warning on line 16 in client/tests/UserSettings.test.jsx GitHub Actions / Using NodeJS and Postgres 12
|
||
describe('user is not signed in', () => { | ||
let wrapper; | ||
beforeEach(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That language may be preferred.