w3c · ccanash · May 16, 2024 · Apr 29, 2024 · May 1, 2024 · May 1, 2024
diff --git a/.gitignore b/.gitignore
@@ -125,3 +125,5 @@ server/migrations/test_plan_target_id.csv
 
 # Private Key files (installed by deploy)
 jwt-signing-key.pem
+
+client/resources
diff --git a/client/resources/aria-at-test-io-format.mjs b/client/resources/aria-at-test-io-format.mjs
@@ -1455,7 +1455,7 @@ export class TestRunInputOutput {
         output: command.atOutput.value,
         assertionResults: command.assertions.map(assertion => ({
           assertion: {
-            priority: assertion.priority === 1 ? 'MUST' : 'SHOULD',
+            priority: assertion.priority === 1 ? 'REQUIRED' : 'OPTIONAL',
             text: assertion.description,
           },
           passed: assertion.result === 'pass',

diff --git a/client/resources/keys.json b/client/resources/keys.json
diff --git a/client/resources/support.json b/client/resources/support.json
@@ -70,6 +70,34 @@
             "Simultaneously press &lt;kbd&gt;Left Arrow&lt;/kbd&gt; and &lt;kbd&gt;Right Arrow&lt;/kbd&gt;.",
             "If VoiceOver said 'quick nav on', press &lt;kbd&gt;Left Arrow&lt;/kbd&gt; and &lt;kbd&gt;Right Arrow&lt;/kbd&gt; again to turn it back off."
           ]
+        },
+        "arrowQuickKeyNavOn": {
+          "screenText": "arrow quick key nav on",
+          "instructions": [
+            "Simultaneously press &lt;kbd&gt;Left Arrow&lt;/kbd&gt; and &lt;kbd&gt;Right Arrow&lt;/kbd&gt;.",
+            "If VoiceOver said 'arrow quick key nav off', press &lt;kbd&gt;Left Arrow&lt;/kbd&gt; and &lt;kbd&gt;Right Arrow&lt;/kbd&gt; again to turn it back on."
+          ]
+        },
+        "arrowQuickKeyNavOff": {
+          "screenText": "arrow quick key nav off",
+          "instructions": [
+            "Simultaneously press &lt;kbd&gt;Left Arrow&lt;/kbd&gt; and &lt;kbd&gt;Right Arrow&lt;/kbd&gt;.",
+            "If VoiceOver said 'arrow quick key nav on', press &lt;kbd&gt;Left Arrow&lt;/kbd&gt; and &lt;kbd&gt;Right Arrow&lt;/kbd&gt; again to turn it back off."
+          ]
+        },
+        "singleQuickKeyNavOn": {
+          "screenText": "single quick key nav on",
+          "instructions": [
+            "Press &lt;kbd&gt;Control&lt;/kbd&gt;+&lt;kbd&gt;Option&lt;/kbd&gt;+&lt;kbd&gt;q&lt;/kbd&gt;.",
+            "If VoiceOver said 'single quick key nav off', press &lt;kbd&gt;Control&lt;/kbd&gt;+&lt;kbd&gt;Option&lt;/kbd&gt;+&lt;kbd&gt;q&lt;/kbd&gt; again to turn it back on."
+          ]
+        },
+        "singleQuickKeyNavOff": {
+          "screenText": "single quick key nav off",
+          "instructions": [
+            "Press &lt;kbd&gt;Control&lt;/kbd&gt;+&lt;kbd&gt;Option&lt;/kbd&gt;+&lt;kbd&gt;q&lt;/kbd&gt;.",
+            "If VoiceOver said 'single quick key nav on', press &lt;kbd&gt;Control&lt;/kbd&gt;+&lt;kbd&gt;Option&lt;/kbd&gt;+&lt;kbd&gt;q&lt;/kbd&gt; again to turn it back off."
+          ]
         }
       }
     }

diff --git a/client/resources/types/aria-at-test-result.js b/client/resources/types/aria-at-test-result.js
@@ -4,8 +4,8 @@
  */
 
 /**
- * @typedef {"MUST"
- *   | "SHOULD"} AriaATTestResult.AssertionPriorityJSON
+ * @typedef {"REQUIRED"
+ *   | "OPTIONAL"} AriaATTestResult.AssertionPriorityJSON
  */
 
 /**

diff --git a/server/migrations/20211116172219-commandSequences.js b/server/migrations/20211116172219-commandSequences.js
@@ -1,6 +1,6 @@
 const { omit } = require('lodash');
 const { TestPlanVersion } = require('../models');
-const commandList = require('../resources/commands.json');
+const commandList = require('../resources/commandsV1.json');
 
 module.exports = {
     up: async queryInterface => {

diff --git a/server/resolvers/helpers/retrieveCommands.js b/server/resolvers/helpers/retrieveCommands.js
@@ -1,4 +1,4 @@
-const commands = require('../../resources/commands.json');
+const commands = require('../../resources/commandsV1.json');
 const commandsV2 = require('../../resources/commandsV2.json');
 
 function findValueByKey(keyMappings, keyToFindText) {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -125,3 +125,5 @@ server/migrations/test_plan_target_id.csv

		# Private Key files (installed by deploy)
		jwt-signing-key.pem

		client/resources
Copy link Contributor howard-e Apr 29, 2024 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Since there are still updates to `client/resources` in this PR, you'll also need to untrack `client/resources` by doing: `git rm -r --cached client/resources`, and push again afterwards. Although, I am now wondering if this should need to be done? It will require that contributors be somewhat aware of when last changes to the `w3c/aria-at` files have happened so they may re-run the import script locally. Otherwise there could be confusion if some `w3c/aria-at`-dependent operations aren't working as expected if the client application's files are updated but not the now ignored aria-at harness changes. My above concern is relatively minor though and seems like a `docs/local-development.md` update could be useful here. Copy link Contributor Author evmiguel May 1, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I added a brief notes in the docs. Copy link Contributor howard-e May 2, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Looks good! After untracking the `client/resources` folder, this PR should be good to go. Copy link Contributor Author evmiguel May 7, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. All set!