Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support in import test script for importing test harness #1064

Merged
merged 6 commits into from
May 16, 2024
Merged

Add support in import test script for importing test harness #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d06025
Add support in import test script for importing test harness
evmiguel Apr 29, 2024
f303ffa
Support older version commits
evmiguel May 1, 2024
240d917
Updating logging messages
evmiguel May 1, 2024
4dd9a42
Remove commands.json from server resources and update commands to com…
evmiguel May 1, 2024
1920ec1
Adding note in local development
evmiguel May 1, 2024
d9ee5a6
Remove client resources from cache
evmiguel May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,5 @@ server/migrations/test_plan_target_id.csv

# Private Key files (installed by deploy)
jwt-signing-key.pem

client/resources
Copy link
Contributor

@howard-e howard-e Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are still updates to client/resources in this PR, you'll also need to untrack client/resources by doing: git rm -r --cached client/resources, and push again afterwards.

Although, I am now wondering if this should need to be done? It will require that contributors be somewhat aware of when last changes to the w3c/aria-at files have happened so they may re-run the import script locally. Otherwise there could be confusion if some w3c/aria-at-dependent operations aren't working as expected if the client application's files are updated but not the now ignored aria-at harness changes.

My above concern is relatively minor though and seems like a docs/local-development.md update could be useful here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a brief notes in the docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! After untracking the client/resources folder, this PR should be good to go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

Loading
Loading