Add better permalinks for AccName computation. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #139 Named IDs and visible step names intended to promote understandability. Retained legacy step IDs (2B or not ii.b) as name attr values so to not break external links.
cookiecrook
commented
Feb 1, 2023
|
Editorial IMO, but since I touched every line of the AccName comp, I'd suggest we review and merge soon, otherwise we'll have a high risk of merge conflicts with other incoming AccName PRs. |
accdc
approved these changes
Feb 4, 2023
MelSumner
approved these changes
Feb 7, 2023
github-actions bot
added a commit
that referenced
this pull request
Feb 7, 2023
SHA: 9c71070 Reason: push, by MelSumner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
Named IDs and visible step names intended to promote understandability. Retained legacy step IDs (2B or not ii.b) as name attr values so to not break external links.
Preview | Diff