-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name
not allowed on a li
element
#214
Comments
They don't appear to be used for anything. Looking at 9c71070, it seems like they were left in place by @cookiecrook during #186. Maybe to facilitate review or perhaps for historical value? In the latter case, we could add a |
Thanks for this detailed explanation, @pkra If @cookiecrook does not object, I'm happy to take this on. I am taking an overall pass at most of the ARIA modules to make them ready for transition to next maturity level. |
According to @jnurthen this was left for old links to keep working. One can do https://github.io/accname/#step1 and be taken to the "Initialization" step under the "Text Equivalent Computation" section. |
It doesn't though -- only for |
Yes. Ideally we'll need to leave non-linked anchors so that older incoming links don't break: <li id="newNamedStepID">
<a name="oldNumberedStepName">Labelledby:</a>
etc etc
</li> |
Cool URIs don't change (or break) |
@w3c/aria-editors Should there be a GitHub hook to include validation as a PR check? |
Not sure what we would check here in addition to what specprod already checks. If you have a look at https://github.com/w3c/accname/actions/runs/6706842952 that is checking links and markup, including the HTML validator, which now fails on |
Ah. I didn't know it was already validating. Now I'm wondering why that didn't get flagged on my original PR #186. |
@cookiecrook We have a much lightweight set of linters for the PRs. I realized the other day because I wanted to make sure we could publish on TR, for winch markup validation and link checkers are compulsory. |
We can't use |
Do you have another resolution in mind? I suppose we could drop the old permalinks. |
Oh I know. We can move the old numbered name to an <li id="newNamedStepID">
<em id="oldNumberedStepName">Labelledby:</em>
etc etc
</li> The |
I created a PR with empty spans with IDs - see above. Seems to validate fine and works |
Not every line with the name attributes has an em element to add it to. Decided adding a span and being consistent was more important |
okay... let's continue in the PR |
Ref: https://validator.w3.org/nu/?showsource=yes&doc=https%3A%2F%2Fw3c.github.io%2Faccname%2F
The HTML checker complains that there is a
name
attribute on ali
element. Can we use another method for this that passes the HTML validator?The text was updated successfully, but these errors were encountered: