Step 2C includes controls with value that are directly referenced by labelledby or describedby #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect current browser behavior
adampage
reviewed
Feb 3, 2023
cookiecrook
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Looks good, but please don't merge this one until after #186 is merged.
MelSumner
approved these changes
Feb 7, 2023
accdc
approved these changes
Mar 1, 2023
|
@MelSumner I think this is ready for merge! Not waiting for any dependent changes. |
adampage
approved these changes
Mar 10, 2023
|
@smhigley could you rebase? Once it's green we're ready to merge. |
MelSumner
added
needs rebase before merge
waiting for author response
and removed
Agenda
labels
This was referenced Nov 3, 2023
|
👋 @smhigley We'd love to get this rebased for a merge, would you be able to do that? |
This was referenced May 23, 2024
|
This PR has been moved to the mono repo: w3c/aria#2210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179, based on discussed resolution
Updates the wording of 2C to specify returning the value text of all controls that allow users to control their value, whether or not they are embedded within a referenced label, or are the referenced label. This is the current real-world behavior of all tested browsers.
I also included controls that are part of an
aria-describedbycalculation, since in testing FF, Chrome, Edge, and Safari, all browsers implement this in practice as well (ref: https://jsfiddle.net/tfogpnvj/ for a reduced example).PR tracking
Check these once you have confirmed the related change is not necessary (also add N/A) OR
when the relevant issue or PR has been made. Leave uncheck if you are unsure. Read the
Process Document or
Test Overview for more information.
Implementation tracking
Preview | Diff