This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
ipld-eth-indexer #29
Merged
ipld-eth-indexer #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if wg.Add(1) in the spun up a goroutine was called after wg.Wait() in the parent process (very unlikely in this case due to the work left between spinning that goroutine up and calling wg.Wait(), but still a race condition)
i-norden
force-pushed
the
eth-ipld-indexer
branch
from
e6b9efa to
d28047a
Compare
i-norden
force-pushed
the
eth-ipld-indexer
branch
from
c983ff1 to
05f98ef
Compare
i-norden
force-pushed
the
eth-ipld-indexer
branch
from
05f98ef to
f389cfa
Compare
i-norden
force-pushed
the
eth-ipld-indexer
branch
from
f389cfa to
678e146
Compare
ramilexe
reviewed
Aug 27, 2020
ramilexe
reviewed
Aug 27, 2020
ramilexe
reviewed
Aug 27, 2020
ramilexe
reviewed
Aug 27, 2020
ramilexe
reviewed
Aug 27, 2020
ramilexe
reviewed
Aug 27, 2020
pkg/eth/retriever_test.go
Outdated
|
|
||
| It("Gets the number of the first block that has data in the database", func() { | ||
| payload := mocks.MockConvertedPayload | ||
| payload.Block = newMockBlock(1010101) |
There was a problem hiding this comment.
let's put this value to variable and reuse it
There was a problem hiding this comment.
Good idea, will do.
ramilexe
reviewed
Aug 27, 2020
ramilexe
reviewed
Aug 27, 2020
i-norden
force-pushed
the
eth-ipld-indexer
branch
from
24de11e to
a0a23dc
Compare
|
Merging now, I still need to merge https://github.com/vulcanize/ipld-eth-server but it needs to use this as a dep so merging this first so we can cut a release |
This was referenced Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further refactoring to focus the code by function and blockchain
Still a few things to do on this branch e.g. update the documentation and this needs to be merged in coordination with merging of PRs on the new repositories spun off from this during the decoupling (ipld-btc-indexer, ipld-eth-server, ipld-btc-server).