Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(all): fix comma dangling error on .ts component files #9622

Closed
wants to merge 1 commit into from
Closed

style(all): fix comma dangling error on .ts component files #9622

wants to merge 1 commit into from

Conversation

adrienbaron
Copy link
Contributor

Description

I ran yarn lint:fix and comited the changes.

Motivation and Context

Running yarn lint on master currently results in a lot of linting error related to the rule 'comma-dangle': ['error', 'always-multiline'].

How Has This Been Tested?

No tests needed as it's only stylistic changes.

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@KaelWD
Copy link
Member

KaelWD commented Nov 8, 2019

Did you accidentally update eslint? This will conflict with #9594

@adrienbaron
Copy link
Contributor Author

I don’t think so, I tried deleting my node_modules and running yarn install again from the root of the project and the issue was still there. Happy to close if nobody else reproduces though.

@KaelWD
Copy link
Member

KaelWD commented Nov 8, 2019

I mean CI is passing and it doesn't happen for me. comma-dangle for functions was added in eslint 6.6.0 and master is only on 6.1.0

@adrienbaron
Copy link
Contributor Author

Ok will close then, I have to figure out what's happening on my machine 👍

@adrienbaron adrienbaron closed this Nov 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants