refactor: update to typescript 3.9 #9594
Conversation
|
Hey @KaelWD, TravisBuddy Request Identifier: ba3de7f0-cbe5-11ea-acda-6fc69b852bf0 |
KaelWD
added
the
S: has merge conflicts
KaelWD
force-pushed
the
master
branch
3 times, most recently
from
9e00958 to
de967ac
Compare
|
Is this still being worked on? |
|
Pulse check. |
|
Still busted, 3.8.3 seems to work though |
KaelWD
changed the title
KaelWD
removed
S: has merge conflicts
jacekkarczmarczyk
added
the
S: has merge conflicts
|
Is this still being worked on? v3 work is about to start heavily. |
KaelWD
removed
S: on hold
packages/vuetify/src/components/VDatePicker/mixins/date-picker-table.ts
Outdated
Show resolved
Hide resolved
| @@ -117,7 +117,8 @@ describe('VTreeView.ts', () => { // eslint-disable-line max-statements | |||
| expect(wrapper.html()).toMatchSnapshot() | |||
| }) | |||
|
|
|||
| it('should load children when expanding', async () => { | |||
| // TODO: fails with TS 3.9 | |||
There was a problem hiding this comment.
This is quite a lot of coverage loss
|
Requesting Final comments from @vuetifyjs/contributors @vuetifyjs/core-team |
| @@ -323,7 +323,7 @@ export default mixins( | |||
| consoleWarn(`Value must be ${this.isMultiple ? 'an' : 'a'} ${expected}, got ${valueType}`, this) | |||
| } | |||
| }, | |||
| isDateAllowed (value: string) { | |||
| isDateAllowed (value: string): boolean { | |||
There was a problem hiding this comment.
This type annotation can be removed as others were for consistency, can't it?
There was a problem hiding this comment.
Same for some ones lower (I think this.$createElement has types)
There was a problem hiding this comment.
Nope, it breaks this without them. The return type inference seems to be getting worse with each version, you used to be able to have computeds without an explicit return type but now it's needed for methods sometimes too.
There was a problem hiding this comment.
😞 okay, that's really bad. I only remember broken this w/o computed types. Maybe we should open an issue to Vue?
Had to skip a bunch of tests that started failing for no reason, if anyone else wants to have a go at fixing them be my guest.
Types of changes