feat: sharp as optional image processor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekoeryanto
commented
Aug 31, 2018
progressive-loader.js
Outdated
| const sharpImg = require('sharp')(path) | ||
|
|
||
| sharpImg | ||
| .webp({ quality: 10 }) |
There was a problem hiding this comment.
should we change to specific format, or just use the same format?
There was a problem hiding this comment.
webp is only support by chrome, so it should definitely default to something else. You should run some examples through to see what ends up smaller, I don't recall the rest of the results from my original tests.
There was a problem hiding this comment.
I tested it. jpeg is smaller than tiff or png, also I have implemented it in https://apek.or.id/about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4