Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using sharp instead of gm as image processor #4

Closed
ekoeryanto opened this issue Aug 30, 2018 · 2 comments
Closed

using sharp instead of gm as image processor #4

ekoeryanto opened this issue Aug 30, 2018 · 2 comments

Comments

@ekoeryanto
Copy link
Contributor

Found my self struggling with Error: Stream yields empty buffer on windows 10.
I think it's better to use the more cross-platform image processor

Thanks.

@KaelWD
Copy link
Member

KaelWD commented Aug 30, 2018

Sharp doesn't support GIF output, so we'd have to use PNG or JPEG instead. I can certainly add an option to use a different processor, but the results will not be nearly as good.
The error may be related to aheckmann/gm#559, I haven't actually tried gm on windows yet.

@ekoeryanto
Copy link
Contributor Author

ekoeryanto commented Aug 31, 2018

thinking about multi image processor support, maybe vuetify-loader/sharp-loader.js

I think aheckmann/gm#559 should be on the README.
installed with scoop that already appended all the binary of imagemagick to the PATH does not work, but installed manually with the install legacy utilities ticked works.

apekarawang added a commit to apekarawang/vuetify-loader that referenced this issue Aug 31, 2018
it fixes vuetifyjs#4 

It is DRY, but I just want to test if it is approved

Thanks.
@KaelWD KaelWD closed this as completed in 804eb3f Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants