Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement] Add assertion to verify using of new #698

Merged
merged 3 commits into from
May 14, 2017
Merged

[improvement] Add assertion to verify using of new #698

merged 3 commits into from
May 14, 2017

Conversation

termosa
Copy link
Contributor

@termosa termosa commented Mar 19, 2017

I see people are asking about this problem so often, that I feel it worth to put this assertion into the code to save some time for those developers.

@termosa
[improvement] Add assertion to verify using of new
be4fffb 
I see people are asking about this problem so often, that
I feel it worth to put this assertion into the code to
save some time for those developers.
ktsn
ktsn requested changes Mar 19, 2017
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert dist/vuex.js because it should only be updated on release time?

@termosa
Copy link
Contributor Author

termosa commented Mar 19, 2017

@ktsn sure, it's here

@ktsn ktsn added 2.x enhancement New feature or request labels Apr 18, 2017
@ktsn ktsn merged commit e0504cc into vuejs:dev May 14, 2017
@kiaking kiaking mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
2.x enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@termosa @ktsn