Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): render initial and used async css chunks #7902

Merged
merged 2 commits into from
Apr 7, 2018

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Mar 27, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This pr is trying to resolve #7897 :

  1. Put splitted chunks of css files into corresponding async and initial int vue-ssr-client-manifest.json
  2. Let renderStyles render initial and used async css files.

@yyx990803 yyx990803 merged commit 575b6e7 into vuejs:dev Apr 7, 2018
@iztsv
Copy link

iztsv commented Apr 27, 2018

@yyx990803 do I understand correctly that this PR will be available in vue 2.6 release?

pi0 pushed a commit to nuxt/nuxt that referenced this pull request May 2, 2018
pi0 pushed a commit to nuxt/nuxt that referenced this pull request May 2, 2018
awamwang added a commit to awamwang/vue that referenced this pull request Jul 8, 2018
* vuejs-dev: (558 commits)
  chore: sponsors
  chore: update sponsors
  chore: update sponsors
  chore: sponsor cleanup
  chore: update sponsors
  chore(package.json): Add sideEffects: false field in package.json (vuejs#8099)
  chore: new sponsor
  chore(typo): no dots at the end of the comments (vuejs#8087)
  chore: new sponsor
  chore: update sponsors
  chore: update sponsors
  chore: use reactive components count in benchmark (vuejs#7996)
  feat(weex): support object syntax of class (vuejs#7930)
  feat(server, webpack-plugin): webpack 4 support (vuejs#7839)
  fix(ssr): render initial and used async css chunks (vuejs#7902)
  fix(ssr): remove trailing hash in webpack module identifier when generating client manifest
  chore: new sponsor
  chore: update sponsor
  build: release 2.5.17-beta.0
  build: build 2.5.17-beta.0
  ...
@chentianyuan
Copy link

when will this feature release .. we really need it

@chentianyuan
Copy link

@yyx990803

@hworld
Copy link

hworld commented Nov 26, 2018

This has been pretty serious for us, since SSR is currently including all stylesheets and styles. With this fix it would actually render out properly again. Is there an estimated release date for when this'll go out in vue?

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
compatibility with webpack 4 + mini CSS extraction

close vuejs#7897
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
compatibility with webpack 4 + mini CSS extraction

close vuejs#7897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue SSR render initial css chunks correctly
5 participants