-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssr): render initial and used async css chunks #7902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yyx990803 do I understand correctly that this PR will be available in vue 2.6 release? |
pi0
pushed a commit
to nuxt/nuxt
that referenced
this pull request
May 2, 2018
pi0
pushed a commit
to nuxt/nuxt
that referenced
this pull request
May 2, 2018
awamwang
added a commit
to awamwang/vue
that referenced
this pull request
Jul 8, 2018
* vuejs-dev: (558 commits) chore: sponsors chore: update sponsors chore: update sponsors chore: sponsor cleanup chore: update sponsors chore(package.json): Add sideEffects: false field in package.json (vuejs#8099) chore: new sponsor chore(typo): no dots at the end of the comments (vuejs#8087) chore: new sponsor chore: update sponsors chore: update sponsors chore: use reactive components count in benchmark (vuejs#7996) feat(weex): support object syntax of class (vuejs#7930) feat(server, webpack-plugin): webpack 4 support (vuejs#7839) fix(ssr): render initial and used async css chunks (vuejs#7902) fix(ssr): remove trailing hash in webpack module identifier when generating client manifest chore: new sponsor chore: update sponsor build: release 2.5.17-beta.0 build: build 2.5.17-beta.0 ...
when will this feature release .. we really need it |
This has been pretty serious for us, since SSR is currently including all stylesheets and styles. With this fix it would actually render out properly again. Is there an estimated release date for when this'll go out in vue? |
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
compatibility with webpack 4 + mini CSS extraction close vuejs#7897
13 tasks
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
compatibility with webpack 4 + mini CSS extraction close vuejs#7897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This pr is trying to resolve #7897 :
async
andinitial
intvue-ssr-client-manifest.json
renderStyles
renderinitial
and usedasync
css files.