feat(server, webpack-plugin): webpack 4 support #7839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
suggested changes
Mar 16, 2018
src/server/webpack-plugin/util.js
Outdated
| export const onEmit = (compiler, name, hook) => { | ||
| if (compiler.hooks) { | ||
| // Webpack >= 4.0.0 | ||
| compiler.hooks.emit.tap(name, |
There was a problem hiding this comment.
Use tapPromise when returning a Promise.
But in this case it makes more sense to use tapAsync which accepts a function with callback.
There was a problem hiding this comment.
Thanks for your review @sokra! :) Does the new changes look good to you?
|
Thanks @pi0 - looks good! Will merge for 2.6. |
awamwang
added a commit
to awamwang/vue
that referenced
this pull request
Jul 8, 2018
* vuejs-dev: (558 commits) chore: sponsors chore: update sponsors chore: update sponsors chore: sponsor cleanup chore: update sponsors chore(package.json): Add sideEffects: false field in package.json (vuejs#8099) chore: new sponsor chore(typo): no dots at the end of the comments (vuejs#8087) chore: new sponsor chore: update sponsors chore: update sponsors chore: use reactive components count in benchmark (vuejs#7996) feat(weex): support object syntax of class (vuejs#7930) feat(server, webpack-plugin): webpack 4 support (vuejs#7839) fix(ssr): render initial and used async css chunks (vuejs#7902) fix(ssr): remove trailing hash in webpack module identifier when generating client manifest chore: new sponsor chore: update sponsor build: release 2.5.17-beta.0 build: build 2.5.17-beta.0 ...
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
SSR webpack 4 compat
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
SSR webpack 4 compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Fixes WP4 deprecated warning:
DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead