Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to vue v3.2.16 and fix devtools #971

Merged
merged 1 commit into from
Sep 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"@types/node": "16.9.6",
"@types/pretty": "^2.0.0",
"@vue/babel-plugin-jsx": "^1.0.7",
"@vue/compat": "3.2.13",
"@vue/compiler-dom": "3.2.13",
"@vue/compiler-sfc": "3.2.13",
"@vue/compat": "3.2.16",
"@vue/compiler-dom": "3.2.16",
"@vue/compiler-sfc": "3.2.16",
"babel-jest": "^26.6.3",
"babel-preset-jest": "^27.2.0",
"husky": "^7.0.1",
Expand All @@ -42,7 +42,7 @@
"tslib": "2.3.1",
"typescript": "4.4.3",
"vitepress": "^0.18.1",
"vue": "3.2.13",
"vue": "3.2.16",
"vue-class-component": "^8.0.0-rc.1",
"vue-jest": "^5.0.0-alpha.10",
"vue-router": "^4.0.11",
Expand Down
2 changes: 1 addition & 1 deletion src/emit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function emitted<T = unknown>(
export const attachEmitListener = () => {
events = {}
// use devtools to capture this "emit"
setDevtoolsHook(createDevTools(events))
setDevtoolsHook(createDevTools(events), this)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the proper value to pass here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is actually - when we do yarn build we get a warning:

src/index.ts → dist/vue-test-utils.esm-browser.js...
(!) Error when using sourcemap for reporting an error: Can't resolve original location of error.
src/emit.ts (1:12)
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
src/emit.ts
1: var _this = this;
               ^
2: import { setDevtoolsHook } from 'vue';
3: var events;

I wonder if this is a false positive. I'll release the next RC and see what happens.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho right, sorry I missed that. Opened a PR to fix it #1011

}

// devtools hook only catches Vue component custom events
Expand Down
111 changes: 106 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1639,10 +1639,10 @@
html-tags "^3.1.0"
svg-tags "^1.0.0"

"@vue/[email protected].13":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/compat/-/compat-3.2.13.tgz#f548b9b71134b68e1aaea01ea49bd02dfae9d6cf"
integrity sha512-UtRa+E9SVTDsF1oqMA43WOBo27r3fSHa3KJQXj2KaSYlO3DpFfLe4OX1YO8r6SLOIC42dmyGCKZpiOPcZGIh9Q==
"@vue/[email protected].16":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/compat/-/compat-3.2.16.tgz#ff70cf34f94f58b5a64251a9955fe800459d2c14"
integrity sha512-klZE6lAZUT/YW2TFEh8fCZMZIpX7ovZjo3Ufa+QqdtC+pttaqvppJ5Zzfcm+br0FT+Ps3Q+MKuGDKwK6vty/VQ==

"@vue/[email protected]":
version "3.2.13"
Expand All @@ -1654,6 +1654,16 @@
estree-walker "^2.0.2"
source-map "^0.6.1"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/compiler-core/-/compiler-core-3.2.16.tgz#aa1c475e5183f24ca93de1bb009b77e63cd189ab"
integrity sha512-60LD3f1GpMtoCPWKP7HacFxv97/EUY8m4WNqfFYmfaILVGO0icojdOCYOfgGFiYC+kgk1MOVdiI4vrWci0CnhQ==
dependencies:
"@babel/parser" "^7.15.0"
"@vue/shared" "3.2.16"
estree-walker "^2.0.2"
source-map "^0.6.1"

"@vue/[email protected]", "@vue/compiler-dom@^3.2.6":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/compiler-dom/-/compiler-dom-3.2.13.tgz#028982494fb9d97807d5275b42355732686f8ed7"
Expand All @@ -1662,6 +1672,14 @@
"@vue/compiler-core" "3.2.13"
"@vue/shared" "3.2.13"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/compiler-dom/-/compiler-dom-3.2.16.tgz#b0748874c4fcf98dfb20efc8a40f629c90c8a620"
integrity sha512-K7lYfwvsp5OLb0+/rKI9XT2RJy2RB7TyJBjvlfCDAF0KOJGqWAx++DLJPm+F3D29Mhxgt6ozSKP+rC3dSabvYA==
dependencies:
"@vue/compiler-core" "3.2.16"
"@vue/shared" "3.2.16"

"@vue/[email protected]", "@vue/compiler-sfc@^3.2.7":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/compiler-sfc/-/compiler-sfc-3.2.13.tgz#a38475048aad9c96cf04dfe635129b417e0f9295"
Expand All @@ -1678,6 +1696,22 @@
postcss "^8.1.10"
source-map "^0.6.1"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/compiler-sfc/-/compiler-sfc-3.2.16.tgz#7e8c372baa0fa93f0c91058d8fa25780f7233f29"
integrity sha512-AxaDDg0ZjY7lCoVnCq7V+K3SIEfhyIHtten7k/LRupVC/VzSbelBmW0J8bawgsjLJAfTsdWZjeezZ5JJp2DM/A==
dependencies:
"@babel/parser" "^7.15.0"
"@vue/compiler-core" "3.2.16"
"@vue/compiler-dom" "3.2.16"
"@vue/compiler-ssr" "3.2.16"
"@vue/ref-transform" "3.2.16"
"@vue/shared" "3.2.16"
estree-walker "^2.0.2"
magic-string "^0.25.7"
postcss "^8.1.10"
source-map "^0.6.1"

"@vue/[email protected]":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/compiler-ssr/-/compiler-ssr-3.2.13.tgz#98434672e0b488c2affa4b0570731d6be5cda187"
Expand All @@ -1686,6 +1720,14 @@
"@vue/compiler-dom" "3.2.13"
"@vue/shared" "3.2.13"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/compiler-ssr/-/compiler-ssr-3.2.16.tgz#7184aac9a69bbde73614eceb726491f7e91350e8"
integrity sha512-u2Inuqp3QpEV3E03ppBLdba40mU0dz/fisbfGjRPlxH5uuQ9v9i5qgrFl7xZ+N5C0ugg5+5KI7MgsbsCAPn0mQ==
dependencies:
"@vue/compiler-dom" "3.2.16"
"@vue/shared" "3.2.16"

"@vue/devtools-api@^6.0.0-beta.11", "@vue/devtools-api@^6.0.0-beta.14":
version "6.0.0-beta.15"
resolved "https://registry.yarnpkg.com/@vue/devtools-api/-/devtools-api-6.0.0-beta.15.tgz#ad7cb384e062f165bcf9c83732125bffbc2ad83d"
Expand All @@ -1698,6 +1740,13 @@
dependencies:
"@vue/shared" "3.2.13"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/reactivity/-/reactivity-3.2.16.tgz#0d4253443d580c906508b0b05b2cd136d46bf4a2"
integrity sha512-eOOpjakbRFg2roaGhVsGgBFnQWaXJcTw66wfc+ZMWl/cihAcgn792gFO1a6KeT68vQBp4JVpGZ5jkkdgZnwFfA==
dependencies:
"@vue/shared" "3.2.16"

"@vue/reactivity@^3.2.6":
version "3.2.11"
resolved "https://registry.yarnpkg.com/@vue/reactivity/-/reactivity-3.2.11.tgz#ec04d33acaf2b92cca2960535bec81b26cc5772b"
Expand All @@ -1716,6 +1765,17 @@
estree-walker "^2.0.2"
magic-string "^0.25.7"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/ref-transform/-/ref-transform-3.2.16.tgz#796a96a205a318b4b0f40bbdace78396c4d0708b"
integrity sha512-IXFgxGnyd5jIXPQ/QlOoz+daeikeR1AA6DujgqalmW/ndCX9ZKW1rhFsoMGR0WAUZ4VHbT3eluUJhBF8ikNzPg==
dependencies:
"@babel/parser" "^7.15.0"
"@vue/compiler-core" "3.2.16"
"@vue/shared" "3.2.16"
estree-walker "^2.0.2"
magic-string "^0.25.7"

"@vue/[email protected]":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/runtime-core/-/runtime-core-3.2.13.tgz#8b62f92642e56af71d0d35a9f0065daf6f9eb3fb"
Expand All @@ -1724,6 +1784,14 @@
"@vue/reactivity" "3.2.13"
"@vue/shared" "3.2.13"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/runtime-core/-/runtime-core-3.2.16.tgz#4c8d909029e595762cb70b97702485bfaf4c047c"
integrity sha512-Y7jDSKpwRmibQSXpGS2xcC2eVF9CuHQ6uPd1BSMy4aJCzB3ATI0CpRm/Ee/a5e70vjd5D9bY9IHe+9I0CIX1Bg==
dependencies:
"@vue/reactivity" "3.2.16"
"@vue/shared" "3.2.16"

"@vue/[email protected]":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/runtime-dom/-/runtime-dom-3.2.13.tgz#238f517a75765719f8373409cee853775c636f92"
Expand All @@ -1733,6 +1801,15 @@
"@vue/shared" "3.2.13"
csstype "^2.6.8"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/runtime-dom/-/runtime-dom-3.2.16.tgz#50aa4afd11fe32f4d70915753411fb387ff9785a"
integrity sha512-PJ/aMaGfXkqFnykNqpDamcMJni4c/nqDQDz0hKncJiVqU4leiFGq7YC2IFbXECdG83GiHFhEc/77WOhecWSmCw==
dependencies:
"@vue/runtime-core" "3.2.16"
"@vue/shared" "3.2.16"
csstype "^2.6.8"

"@vue/[email protected]", "@vue/server-renderer@^3.2.7":
version "3.2.13"
resolved "https://registry.yarnpkg.com/@vue/server-renderer/-/server-renderer-3.2.13.tgz#b10a564be67eec6721f90b36c3c817c19e6064b4"
Expand All @@ -1741,6 +1818,14 @@
"@vue/compiler-ssr" "3.2.13"
"@vue/shared" "3.2.13"

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/server-renderer/-/server-renderer-3.2.16.tgz#791e47957c16f31e53a773c27b0b88d8095d4586"
integrity sha512-g2aSNYHaExFElYmKw1bfmp3yQmBCPQzrX3Hd7bhDa7bbGGHGchOg0n31SwuMrGk/z/pho4Z0K+LPfChmcECynQ==
dependencies:
"@vue/compiler-ssr" "3.2.16"
"@vue/shared" "3.2.16"

"@vue/[email protected]":
version "3.2.11"
resolved "https://registry.yarnpkg.com/@vue/shared/-/shared-3.2.11.tgz#01899f54949caf1ac241de397bd17069632574de"
Expand All @@ -1751,6 +1836,11 @@
resolved "https://registry.yarnpkg.com/@vue/shared/-/shared-3.2.13.tgz#c830ef966d7af12598e0ea862a55695ea589cd47"
integrity sha512-F/gs3kHQ8Xeo24F6EImOvBiIoYQsBjF9qoLzvk+LHxYN6ZhIDEL1NWrBFYzdFQ7NphjEYd4EvPZ+Qee+WX8P6w==

"@vue/[email protected]":
version "3.2.16"
resolved "https://registry.yarnpkg.com/@vue/shared/-/shared-3.2.16.tgz#a7f5e37e07ac68d4b7ea8ebeba515b46d205c524"
integrity sha512-zpv8lxuatl3ruCJCsGzrO/F4+IlLug4jbu3vaIi/wJVZKQgnsW1R/xSRJMQS6K57cl4fT/2zkrYsWh1/6H7Esw==

abab@^2.0.0, abab@^2.0.3, abab@^2.0.5:
version "2.0.5"
resolved "https://registry.yarnpkg.com/abab/-/abab-2.0.5.tgz#c0b678fb32d60fc1219c784d6a826fe385aeb79a"
Expand Down Expand Up @@ -6668,7 +6758,18 @@ [email protected]:
dependencies:
vscode-vue-languageservice "^0.27.0"

[email protected], vue@^3.2.7:
[email protected]:
version "3.2.16"
resolved "https://registry.yarnpkg.com/vue/-/vue-3.2.16.tgz#bc547784b5df360cfa64d72fd0b94cd20149cf1e"
integrity sha512-aGm8HbZe6IIj2b/LX6QXpAwwDFrpo8E1jdTkuBX2fS42c1+mQ1n0Wl+Dxnj9cgRM7bp1MIoXbPbDyDsOrXTO0w==
dependencies:
"@vue/compiler-dom" "3.2.16"
"@vue/compiler-sfc" "3.2.16"
"@vue/runtime-dom" "3.2.16"
"@vue/server-renderer" "3.2.16"
"@vue/shared" "3.2.16"

vue@^3.2.7:
version "3.2.13"
resolved "https://registry.yarnpkg.com/vue/-/vue-3.2.13.tgz#9d1a94fc62dc29ae21a3dd0d8ee24198e421671e"
integrity sha512-raTGvLXXTdMxrhQKY1r1YFXZMmjbjTe7QHBW9EU4CgCBhq8DbgyLqgILcSUZmeFyazk5WY7a7xu0VYmHElf4lA==
Expand Down