chore: bump to vue v3.2.16 and fix devtools #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a breaking change in the devtool API as `setDevtoolsHook` now needs a second parameter. vuejs/core@2476eaa#diff-56930a63772d2e89f19432918b9d6ed851ede4159b0d32404e0c1d8c159fec99R346
cexbrayat
commented
Sep 24, 2021
| @@ -30,7 +30,7 @@ export function emitted<T = unknown>( | |||
| export const attachEmitListener = () => { | |||
| events = {} | |||
| // use devtools to capture this "emit" | |||
| setDevtoolsHook(createDevTools(events)) | |||
| setDevtoolsHook(createDevTools(events), this) | |||
There was a problem hiding this comment.
I think this is the proper value to pass here
There was a problem hiding this comment.
Not sure this is actually - when we do yarn build we get a warning:
src/index.ts → dist/vue-test-utils.esm-browser.js...
(!) Error when using sourcemap for reporting an error: Can't resolve original location of error.
src/emit.ts (1:12)
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
src/emit.ts
1: var _this = this;
^
2: import { setDevtoolsHook } from 'vue';
3: var events;
I wonder if this is a false positive. I'll release the next RC and see what happens.
There was a problem hiding this comment.
Ho right, sorry I missed that. Opened a PR to fix it #1011
This was referenced Sep 24, 2021
|
Merging this one even if not reviewed as it unblocks dependabot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change in the devtools API as
setDevtoolsHooknow needs a second parameter.vuejs/core@2476eaa#diff-56930a63772d2e89f19432918b9d6ed851ede4159b0d32404e0c1d8c159fec99R346