fix: globalProperties config leak (#1187) #1202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1187 by doing 1st-level-pseudo-deep-clone merge of Vue's AppConfig (only the props that we know are objects -
globalProperties
andcompilerOptions
).I was tempted to use lodash's
clondeDeep
but didn't want to bring another dependency. (looked atlodash.clonedeep
as well but thelodash.*
packages are not updated anymore). Not loving howmergeAppConfig()
turned out but it does the job without additional dependencies. Open to alternatives :)This might break existing tests if they rely on the buggy behavior but i don't think it should be considered breaking changes 🤔
Copy of the original issue and repro: