-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config leaks between tests #1187
Comments
Thanks @purepear for the repro 👍 Would you like to work on a PR to fix this? If you add this test to |
@cexbrayat yep, i will see if i can raise a PR during the weekend. Haven't looked too deep into the code but i suspect |
Thanks for the great work, guys! 🙇
I just noticed that when i pass the router plugin in a test, then the rest of the tests were inheriting the router.
I also have a global config setup:
I believe it has sth to do with the config merging strategy - it uses shallow clone and in the case of deeply nested objects, it overwrites the VTU's global config object. This might not be limited to plugins/config/globalProperties but other parts of the config as well 🤔
Here's how to reproduce:
The text was updated successfully, but these errors were encountered: