chore(findComponent): refactor find & findComponent (fixes #716, #899) #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow find also find DOM nodes by ref * generalize findAll/findAll components behavior * greatly improve typings * add types tests for findComponent
xanf
changed the title
|
side note: please do not do immediate release on merging this one, I have two more PRs to do right on top of this one |
|
Let me know when you'd like another release of VTU :) |
|
@xanf I don't fully understand why this change was necessary? Can you help me understand? |
|
@nandi95 This is intended change. Consider following component: <template>
<template v-if="false">Hello</template>
</template>This will result in component being rendering as single Node |
|
That makes sense. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reopen of #1094 which was occasionally merged by me, and immediately force-pushed in master to revert merge
/cc @lmiller1990 @cexbrayat