Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing of findAllComponents #899

Closed
xanf opened this issue Aug 30, 2021 · 1 comment
Closed

Improve typing of findAllComponents #899

xanf opened this issue Aug 30, 2021 · 1 comment
Labels
typescript

Comments

@xanf
Copy link
Collaborator

xanf commented Aug 30, 2021

See #897 (comment) for original discussion

findAllComponents is incorrectly typed by VueWrapper[], where T - is a type of original wrapper, not the selector. We should explore possibility of improving this typing to provide better error-free experience for TypeScript users
@xanf xanf mentioned this issue Aug 30, 2021
Merged
xanf added a commit that referenced this issue Nov 26, 2021
@xanf
Revert "chore(findComponent): refactor find & findComponent (fixes #716…
4ee1fd0 
…, #899)"
lmiller1990 pushed a commit that referenced this issue Nov 29, 2021
@xanf
chore(findComponent): refactor find & findComponent (fixes #716, #899) (
81dc7f1 
#1110)

* chore(findComponent): refactor find & findComponent

* allow find also find DOM nodes by ref
* generalize findAll/findAll components behavior
* greatly improve typings
* add types tests for findComponent

* chore: fix recursive deps using dedicated factory
@xanf
Copy link
Collaborator Author

xanf commented Dec 18, 2021

✅ closed via #1110

@xanf xanf closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xanf @lmiller1990