Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): mark the effect as recursive if there's updates during the run #10090

Closed
wants to merge 1 commit into from
Closed

fix(reactivity): mark the effect as recursive if there's updates during the run #10090

wants to merge 1 commit into from

Conversation

pikax
Copy link
Member

@pikax pikax commented Jan 12, 2024

close #10082

The test that fixes #2043 is contradicting this PR, not sure if the #2043 should be handle differently

@pikax pikax added the 🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. label Jan 12, 2024
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.9 kB (+136 B) 34.2 kB (+49 B) 30.9 kB (+35 B)
vue.global.prod.js 147 kB (+136 B) 53.5 kB (+50 B) 47.7 kB (-25 B)

Usages

Name Size Gzip Brotli
createApp 50.3 kB (+133 B) 19.7 kB (+43 B) 17.9 kB (-12 B)
createSSRApp 53.6 kB (+133 B) 21 kB (+45 B) 19.1 kB (+29 B)
defineCustomElement 52.5 kB (+133 B) 20.4 kB (+44 B) 18.7 kB (+104 B)
overall 64 kB (+133 B) 24.7 kB (+43 B) 22.5 kB (+64 B)

@Doctor-wu
Copy link
Member

Maybe properly fixed in #10091

@yyx990803 yyx990803 mentioned this pull request Jan 12, 2024
Merged
@yyx990803 yyx990803 removed the 🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. label Jan 12, 2024
@yyx990803
Copy link
Member

I'm not sure if this is something we should account for (mutating state in a computed getter) as this is something we explicitly warn people against in the docs.

@pikax pikax closed this Jan 12, 2024
johnsoncodehk added a commit to johnsoncodehk/core that referenced this pull request Jan 13, 2024
@johnsoncodehk
fix(reactivity): fix vuejs#10085, vuejs#10090 test
c533d3b
@johnsoncodehk johnsoncodehk mentioned this pull request Jan 13, 2024
Merged
@Doctor-wu Doctor-wu mentioned this pull request Jan 15, 2024
Merged
@johnsoncodehk johnsoncodehk mentioned this pull request Jan 16, 2024
Merged
@edison1105 edison1105 deleted the pikax/computed_render_issue branch October 21, 2024 07:37
@edison1105 edison1105 restored the pikax/computed_render_issue branch October 21, 2024 08:14
@edison1105 edison1105 reopened this Oct 21, 2024
@edison1105 edison1105 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@pikax @Doctor-wu @yyx990803 @edison1105