Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): properly avoid effect recurse #10085

Closed
wants to merge 1 commit into from
Closed

fix(reactivity): properly avoid effect recurse #10085

wants to merge 1 commit into from

Conversation

edison1105
Copy link
Member

close #10082

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.7 kB (+8 B) 34.2 kB (+4 B) 30.8 kB (-8 B)
vue.global.prod.js 147 kB (+8 B) 53.4 kB (+5 B) 47.8 kB (+3 B)

Usages

Name Size Gzip Brotli
createApp 50.1 kB (+7 B) 19.6 kB (+3 B) 17.9 kB (-3 B)
createSSRApp 53.4 kB (+7 B) 20.9 kB (+3 B) 19.1 kB (-6 B)
defineCustomElement 52.4 kB (+7 B) 20.4 kB (+4 B) 18.6 kB (+7 B)
overall 63.8 kB (+7 B) 24.7 kB (+3 B) 22.4 kB (+19 B)

@edison1105 edison1105 closed this Jan 12, 2024
johnsoncodehk added a commit to johnsoncodehk/core that referenced this pull request Jan 13, 2024
@johnsoncodehk
fix(reactivity): fix vuejs#10085, vuejs#10090 test
c533d3b
@johnsoncodehk johnsoncodehk mentioned this pull request Jan 13, 2024
Merged
@Doctor-wu Doctor-wu mentioned this pull request Jan 15, 2024
Merged
@johnsoncodehk johnsoncodehk mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Providing a computed prop to child breaks the reactivity of the computed
1 participant
@edison1105