Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint in config folder #1092

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Fix eslint in config folder #1092

merged 2 commits into from
Mar 16, 2020

Conversation

emersonlaurentino
Copy link
Member

What is the purpose of this pull request?

#trivial Fix eslint errors #1082

What problem is this solving?

Fix eslint in config folder

How should this be manually tested?

yarn lint

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@emersonlaurentino emersonlaurentino requested a review from a team March 13, 2020 21:21
@emersonlaurentino emersonlaurentino requested a review from a team as a code owner March 13, 2020 21:21
@emersonlaurentino emersonlaurentino self-assigned this Mar 13, 2020
@emersonlaurentino emersonlaurentino mentioned this pull request Mar 13, 2020
Closed
74 tasks
igorbrasileiro
igorbrasileiro approved these changes Mar 16, 2020
View reviewed changes
Copy link

@igorbrasileiro igorbrasileiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersonlaurentino emersonlaurentino merged commit 81b982f into features Mar 16, 2020
@emersonlaurentino emersonlaurentino deleted the fix-eslint-config branch March 16, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbrasileiro igorbrasileiro igorbrasileiro approved these changes

Assignees

@emersonlaurentino emersonlaurentino

Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersonlaurentino @igorbrasileiro