Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all eslint problems in the project #1082

Closed
74 tasks done
emersonlaurentino opened this issue Mar 12, 2020 · 8 comments
Closed
74 tasks done

Fix all eslint problems in the project #1082

emersonlaurentino opened this issue Mar 12, 2020 · 8 comments
Labels
✨ Enhancement good first issue This is a good issue for someone that is starting to contribute to this styleguide.

Comments

@emersonlaurentino
Copy link
Member

emersonlaurentino commented Mar 12, 2020 •
edited by matheusps
Loading

There are currently a lot of errors and warnings because of the eslint update in #1080.

The purpose of this issue is to fix all the eslint errors that currently exist so that issue #1081 can be resolved.

Files:
@emersonlaurentino emersonlaurentino added ✨ Enhancement good first issue This is a good issue for someone that is starting to contribute to this styleguide. labels Mar 12, 2020
This was referenced Mar 12, 2020
Open
Merged
Merged
This was referenced Mar 18, 2020
Merged
Merged
@emersonlaurentino
Copy link
Member Author

emersonlaurentino commented Mar 18, 2020 •
edited
Loading

I will fix the file problems:

  • /react/modules/deprecated.tsx
  • /scripts/entrypoints.js
  • /scripts/version.js
  • /styleguide.config.js
  • /styleguide.styles.js

This was referenced Mar 18, 2020
Merged
Merged
Merged
@emersonlaurentino emersonlaurentino mentioned this issue Mar 19, 2020
Open
@igorbrasileiro igorbrasileiro mentioned this issue Mar 25, 2020
Merged
4 tasks
@emersonlaurentino emersonlaurentino mentioned this issue Apr 9, 2020
Merged
4 tasks
@emersonlaurentino
Copy link
Member Author

I will fix the EXPERIMENTALS problems

@emersonlaurentino emersonlaurentino mentioned this issue Apr 9, 2020
Closed
4 tasks
@thayannevls
Copy link
Contributor

I will fix these ones:

  • /react/components/Tooltip/Portal.tsx
  • /react/components/Tooltip/TooltipPopup.tsx
  • /react/components/Tooltip/hooks.ts
  • /react/components/Tooltip/utils/dom.ts
  • /react/components/index.js

@igorbrasileiro igorbrasileiro mentioned this issue Apr 9, 2020
Merged
4 tasks
@igorbrasileiro
Copy link

igorbrasileiro commented Apr 9, 2020 •
edited
Loading

I will fix the EXPERIMENTALS problems

I solved from ButtonGroup #1163

@igorbrasileiro
Copy link

I will fix these ones:

  • /react/components/Conditions/StrategySelector.tsx
  • /react/components/Conditions/index.tsx

@igorbrasileiro
Copy link

I have a doubt, what to do with DIVs with onClick property?

@thayannevls
Copy link
Contributor

@igorbrasileiro add role="button" for now. We will look for a better solution for this in the future 😄

@igorbrasileiro igorbrasileiro mentioned this issue Apr 16, 2020
Merged
4 tasks
This was referenced May 21, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 28, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@matheusps
Copy link
Contributor

🥳 Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ Enhancement good first issue This is a good issue for someone that is starting to contribute to this styleguide.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thayannevls @matheusps @emersonlaurentino @igorbrasileiro