Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint in alert component #1091

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Fix eslint in alert component #1091

merged 2 commits into from
Mar 13, 2020

Conversation

emersonlaurentino
Copy link
Member

@emersonlaurentino emersonlaurentino commented Mar 13, 2020 •
edited
Loading

What is the purpose of this pull request?

#trivial Fix eslint errors #1082

What problem is this solving?

Fix eslint in alert component

How should this be manually tested?

yarn lint

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@emersonlaurentino emersonlaurentino requested a review from a team March 13, 2020 20:16
@emersonlaurentino emersonlaurentino requested a review from a team as a code owner March 13, 2020 20:16
@emersonlaurentino emersonlaurentino self-assigned this Mar 13, 2020
lucasecdb
lucasecdb suggested changes Mar 13, 2020
View reviewed changes
react/components/Alert/index.js Outdated Show resolved Hide resolved
@emersonlaurentino emersonlaurentino merged commit 5db3e4d into features Mar 13, 2020
@emersonlaurentino emersonlaurentino deleted the fix-eslint-alert branch March 13, 2020 21:06
@emersonlaurentino emersonlaurentino mentioned this pull request Mar 13, 2020
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasecdb lucasecdb lucasecdb approved these changes

@klzns klzns klzns approved these changes

Assignees

@emersonlaurentino emersonlaurentino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersonlaurentino @klzns @lucasecdb