Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fifo reading if named pipe remains open #55

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Fix fifo reading if named pipe remains open #55

merged 5 commits into from
Nov 21, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Nov 21, 2022 •
edited
Loading

Summary

Keepalived FIFO did not quite work as expected. This update will correctly work even if the sending pipe never sends an EOF

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@glrf glrf added the ignore label Nov 21, 2022
@glrf glrf self-assigned this Nov 21, 2022
@glrf glrf marked this pull request as ready for review November 21, 2022 12:22
@glrf glrf requested a review from a team November 21, 2022 12:22
simu
simu approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glrf glrf merged commit 05ff965 into master Nov 21, 2022
@glrf glrf deleted the fix/read-line branch November 21, 2022 12:27
@simu simu mentioned this pull request Nov 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees

@glrf glrf

Labels
ignore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glrf @simu