Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different managed-addresses for different VRRP instances in FIFO mode #57

Open
simu opened this issue Nov 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Nov 21, 2022

Summary

As an operator of Keepalived+Floaty setups
I want to be able to use Floaty's FIFO mode for configurations with multiple independent VRRP instances with different VIPs
So that I can profit from the advantages of FIFO mode without being restricted in the possible configurations that work with FIFO mode.

Context

We've added initial support for FIFO mode in #51, but didn't consider more complex Keepalived setups with multiple VRRP instances which may transition between states independently. Currently, Floaty in FIFO mode only works correctly for Keepalived configurations with a single VRRP instance which contains all addresses specified in Floaty's managed-addresses configuration.

We should extend Floaty's config to allow configuration files to contain multiple managed-addresses configurations for different VRRP instances so that Floaty can manage those VIP sets independently when the corresponding VRRP instance's state changes.

Out of Scope

  • Extend the VSHN-internal Puppet profile to support the new feature

Further links

Acceptance criteria

  • Floaty FIFO mode can manage multiple sets of VIPs (one set per VRRP instance) independently

Implementation Ideas

  • Change config to have a new key which is only read in FIFO mode which contains a map from VRRP instance name to VIPs (similar to managed-addresses currently)
  • Fix or replace Floaty's keepalived config parsing to support extracting the VIPs associated with a VRRP instance directly from the Keepalived config
@simu simu added the enhancement New feature or request label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant