Add option to run with notify fifo #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glrf
force-pushed
the
feat/fifo
branch
8 times, most recently
from
be9d035 to
fcb3e70
Compare
simu
approved these changes
Nov 17, 2022
Comment on lines
+40
to
+42
| // Yes, this can actually be parsed as a CSV file with spaces as separators and it handles quoted string the same way a shell does. | ||
| r := csv.NewReader(h.pipe) | ||
| r.Comma = ' ' |
bastjan
approved these changes
Nov 17, 2022
| lines, err := r.ReadAll() | ||
| if err != nil { | ||
| logrus.Errorf("Failed to read from fifo: %s", err) | ||
| continue |
There was a problem hiding this comment.
I guess that's fine since we wait for the next update to try again. So no log spamming/looping should occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog