Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.60.2: JUnit is in the compile scope #385

Closed
markkolich opened this issue Feb 11, 2020 · 2 comments
Closed

0.60.2: JUnit is in the compile scope #385

markkolich opened this issue Feb 11, 2020 · 2 comments

Comments

@markkolich
Copy link
Contributor

markkolich commented Feb 11, 2020 •
edited
Loading

Hi @vsch, I just upgraded my project to 0.60.2 and it looks like junit:junit:4.12 is incorrectly in the compile scope of flexmark-util:

flexmark-java/flexmark-util/pom.xml

Lines 71 to 74 in 9b3c0be

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>

I assume this is not intentional, and this dependency should be in the test scope instead?

Related:
markkolich added a commit to markkolich/flexmark-java that referenced this issue Feb 17, 2020
@markkolich
JUnit is in the compile scope (vsch#385)
aebfa54
@markkolich
Copy link
Contributor Author

Opened PR #387 to correct this.

vsch pushed a commit that referenced this issue Feb 18, 2020
@markkolich
JUnit is in the compile scope (#385) (#387)
9dab658
@markkolich
Copy link
Contributor Author

Fixed with #387.

@koppor koppor mentioned this issue Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markkolich