Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.40.0: JUnit is in the compile scope #292

Closed
markkolich opened this issue Dec 25, 2018 · 4 comments
Closed

0.40.0: JUnit is in the compile scope #292

markkolich opened this issue Dec 25, 2018 · 4 comments

Comments

@markkolich
Copy link
Contributor

Hi @vsch, I was tempted to re-open #291 but I opted to file a separate bug instead.

I migrated my project to com.vladsch.flexmark:flexmark version 0.40.0 and I still see junit:junit in the compile scope:

[INFO] +- com.vladsch.flexmark:flexmark:jar:0.40.0:compile
[INFO] |  +- com.vladsch.flexmark:flexmark-test-util:jar:0.40.0:compile
[INFO] |  |  \- junit:junit:jar:4.12:compile << -- !!
[INFO] |  |     \- org.hamcrest:hamcrest-core:jar:1.3:compile
[INFO] |  \- com.vladsch.flexmark:flexmark-util:jar:0.40.0:compile

Is that intentional?

@vsch
Copy link
Owner

vsch commented Dec 31, 2018

@markkolich, I will check, I thought I marked the dependency as test scope.

@vsch
Copy link
Owner

vsch commented Jan 7, 2019

@markkolich, I removed the code but left in the redundant import and forgot to add test scope in the pom.

0.40.2 fixes this.

@vsch
Copy link
Owner

vsch commented Jan 7, 2019

Fix for this is available. Repo updated, maven updated but may take a while to show up in maven central.

@vsch vsch added this to the Version 0.4.0 milestone Jan 7, 2019
@markkolich
Copy link
Contributor Author

@vsch confirmed fixed with 0.40.2. Thanks!

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants