(breaking change) bump crystal support to 1.6.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On upgrading to next crystal version, the following error was observed:
This is due to change in behaviour introduced in Crystal 1.6.0, where
File::Infobecame astructand in earlier versions. it wasabstract struct. Additionally, in the latest versionCrystal::System::FileInfobecame a moduleIssue: crystal-lang/crystal#12385
The new version of libarchive (3.7.4) does not throw error when the archive has bad files. The previous version used in this build was 3.4.x). Modified the check to throw error when none of the files in the archive have valid files.