Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose Crystal::System::FileInfo through File::Info #12385

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Do not expose Crystal::System::FileInfo through File::Info #12385

merged 1 commit into from
Aug 16, 2022

Conversation

HertzDevil
Copy link
Contributor

Supersedes #11825. Resolves #7685.

Crystal::System::FileInfo is now a module and File::Info is no longer abstract.

@straight-shoota straight-shoota added this to the 1.6.0 milestone Aug 14, 2022
@straight-shoota straight-shoota merged commit b370a86 into crystal-lang:master Aug 16, 2022
@HertzDevil HertzDevil deleted the refactor/file-info2 branch August 17, 2022 13:19
@straight-shoota straight-shoota mentioned this pull request Sep 10, 2022
Closed
@vrsandeep vrsandeep mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
breaking-change kind:refactor topic:stdlib:files
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

File.info? returns Crystal::System::FileInfo, not File::Info
2 participants
@HertzDevil @straight-shoota