Add MToon0X -> MToon10 material migration command #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
commented
May 25, 2024
| @@ -3,7 +3,6 @@ | |||
| "rootNamespace": "", | |||
| "references": [ | |||
| "GUID:2ef84b520212e174a94668c7a0862d3b", | |||
| "GUID:a9bc101fb0471f94a8f99fd242fdd934", | |||
There was a problem hiding this comment.
VRM10 -> MToon0X の asmdef 参照は今後のリファクタ時に障害になるので削除
| @@ -355,7 +353,8 @@ public static void Migrate(glTF gltf, JsonNode vrm0) | |||
| ); | |||
| } | |||
| } | |||
| dst.UvAnimationRotationSpeedFactor = mtoon.Definition.TextureOption.UvAnimationRotationSpeedValue; | |||
| const float rotationPerSecToRadianPerSec = Mathf.PI * 2f; | |||
| dst.UvAnimationRotationSpeedFactor = mtoon.Definition.TextureOption.UvAnimationRotationSpeedValue * rotationPerSecToRadianPerSec; | |||
There was a problem hiding this comment.
のときにマイグレーションの方を修正できていなかった
Santarh
commented
May 25, 2024
|
|
||
| namespace VRMShaders.VRM10.MToon10.Runtime.MToon0X | ||
| { | ||
| public class MToon0XDefinition |
There was a problem hiding this comment.
こういうクラス public にしたくないのだが、現状せざるを得ない
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VRM/MToonシェーダの Material アセットをVRM10/MToon10シェーダにマイグレーションします。これは Material アセットに完結した機能で、手動セットアップ時等に便利です。
ついでに