Remove use of legacy facts #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
remove_use_of_legacy_facts
branch
from
0885da0 to
230ef78
Compare
tuxmea
approved these changes
Mar 14, 2023
ekohl
requested changes
Mar 14, 2023
lib/voxpupuli/test/facts.rb
Outdated
| @@ -71,7 +71,7 @@ def add_stdlib_facts | |||
| # Rough conversion of grepping in the puppet source: | |||
| # grep defaultfor lib/puppet/provider/service/*.rb | |||
| add_custom_fact :service_provider, ->(os, facts) do | |||
| case facts[:osfamily].downcase | |||
| case facts[:os]['family'].downcase | |||
There was a problem hiding this comment.
I'd like to respect RSpec.configuration.facterdb_string_keys from rspec-puppet-facts:
Suggested change
| case facts[:os]['family'].downcase | |
| os = RSpec.configuration.facterdb_string_keys ? facts['os'] : facts[:os] | |
| case os['family'].downcase |
And change the fact below as well.
Then we're ready for changing that default in the future.
At some point soon, either facterdb will stop providing legacy facts or rspec-puppet-facts will be configurable to filter them out. Either way, we should not rely on them in this gem and use the modern counterparts instead.
alexjfisher
force-pushed
the
remove_use_of_legacy_facts
branch
from
230ef78 to
d6eb991
Compare
tuxmea
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point soon, either facterdb will stop providing legacy facts or rspec-puppet-facts will be configurable to filter them out. Either way, we should not rely on them in this gem and use the modern counterparts instead.