Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Naming/PredicateName: Add is_to_s to AllowedMethods #74

Merged
merged 1 commit into from
Mar 14, 2022
Merged

rubocop: Naming/PredicateName: Add is_to_s to AllowedMethods #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ Style/PerlBackrefs:

Naming/PredicateName:
Enabled: True
AllowedMethods: ['is_a', 'is_to_s']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have been...

Suggested change
AllowedMethods: ['is_a', 'is_to_s']
AllowedMethods: ['is_a?', 'is_to_s']

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yea the default was with ?
I'll push another PR and fix it


Style/RedundantException:
Enabled: True
Expand Down