Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Naming/PredicateName: Add is_to_s to AllowedMethods #74

Merged
merged 1 commit into from
Mar 14, 2022
Merged

rubocop: Naming/PredicateName: Add is_to_s to AllowedMethods #74

merged 1 commit into from
Mar 14, 2022

Conversation

root-expert
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 14, 2022 •
edited
Loading

Codecov Report

Merging #74 (d06a133) into master (05ebb64) will not change coverage.
The diff coverage is n/a.

❗ Current head d06a133 differs from pull request most recent head 83af2ec. Consider uploading reports for the commit 83af2ec to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files           2        2           
  Lines          61       61           
=======================================
  Hits           17       17           
  Misses         44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ebb64...83af2ec. Read the comment docs.

ekohl
ekohl approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are there more we should capture?

@root-expert
Copy link
Member Author

Looks good. Are there more we should capture?

I was wondering the same. Nothing coming up on my mind, maybe someone else has an idea

@ekohl ekohl added the bug Something isn't working label Mar 14, 2022
@ekohl ekohl merged commit bf1a61a into master Mar 14, 2022
@ekohl ekohl deleted the predicatename branch March 14, 2022 16:11
alexjfisher
alexjfisher reviewed Mar 14, 2022
View reviewed changes
rubocop.yml
@@ -439,6 +439,7 @@ Style/PerlBackrefs:

Naming/PredicateName:
Enabled: True
AllowedMethods: ['is_a', 'is_to_s']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have been...

Suggested change
AllowedMethods: ['is_a', 'is_to_s']
AllowedMethods: ['is_a?', 'is_to_s']

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yea the default was with ?
I'll push another PR and fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@root-expert @alexjfisher @ekohl