Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default facter version from rspec-puppet-facts #49

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Use default facter version from rspec-puppet-facts #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions lib/voxpupuli/test/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,3 @@
# getting the correct facter version is tricky. We use facterdb as a source to mock facts
# see https://github.com/camptocamp/facterdb
# people might provide a specific facter version. In that case we use it.
# Otherwise we need to match the correct facter version to the used puppet version.
# as of 2019-10-31, puppet 5 ships facter 3.11 and puppet 6 ships facter 3.14
# https://puppet.com/docs/puppet/5.5/about_agent.html
#
# The environment variable `PUPPET_VERSION` is available in our travis environment, but we cannot rely on it
# if somebody runs the tests locally. For that case we should fallback the the puppet gem version.
def suggest_facter_version
return ENV['FACTERDB_FACTS_VERSION'] if ENV['FACTERDB_FACTS_VERSION']

require 'bundler'
puppet_version = ENV['PUPPET_VERSION'] ? ENV['PUPPET_VERSION'] : Gem.loaded_specs['puppet'].version.to_s
Gem::Dependency.new('', puppet_version).match?('', '5') ? '3.11.0' : '3.14.0'
end

RSpec.configure do |config|
# puppetlabs_spec_helper defaults to mocha but emits a deprecation warning
# Vox Pupuli prefers rspec to avoid the deprecation warning unless explicitly
Expand All @@ -28,9 +11,6 @@ def suggest_facter_version
require 'puppetlabs_spec_helper/module_spec_helper'

RSpec.configure do |config|
config.default_facter_version = suggest_facter_version

# Coverage generation
config.after(:suite) do
RSpec::Puppet::Coverage.report!
end
Expand Down