Use default facter version from rspec-puppet-facts #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rspec-puppet-facts 2.0.0 the default Facter version is derived from the Puppet version. There is no more need to do this locally. It also handles Puppet 7 which our code doesn't.
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 25.75% 25.75%
=======================================
Files 2 2
Lines 66 66
=======================================
Hits 17 17
Misses 49 49 Continue to review full report at Codecov.
|
|
ah sorry for the early merge, I realized the |
bastelfreak
added a commit
to bastelfreak/puppet-borg
that referenced
this pull request
Aug 11, 2021
this is a test for voxpupuli/voxpupuli-test#49
|
tested it in voxpupuli/puppet-borg#118 |
bastelfreak
added a commit
to bastelfreak/puppet-borg
that referenced
this pull request
Aug 13, 2021
this is a test for voxpupuli/voxpupuli-test#49
bastelfreak
added a commit
to voxpupuli/puppet-borg
that referenced
this pull request
Aug 13, 2021
this is a test for voxpupuli/voxpupuli-test#49
bastelfreak
added a commit
to voxpupuli/puppet-borg
that referenced
this pull request
Aug 13, 2021
this is a test for voxpupuli/voxpupuli-test#49
bastelfreak
added a commit
to voxpupuli/puppet-borg
that referenced
this pull request
Aug 13, 2021
this is a test for voxpupuli/voxpupuli-test#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rspec-puppet-facts 2.0.0 the default Facter version is derived from the Puppet version. There is no more need to do this locally. It also handles Puppet 7 which our code doesn't.
I should note I didn't test this yet.