Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add puppet-lint-manifest_whitespace-check #22

Merged
merged 1 commit into from
Jun 27, 2020
Merged

add puppet-lint-manifest_whitespace-check #22

merged 1 commit into from
Jun 27, 2020

Conversation

bastelfreak
Copy link
Member

why extensivly tested this in voxpupuli/puppet-collectd#947

@bastelfreak bastelfreak added the enhancement New feature or request label Jun 26, 2020
@bastelfreak bastelfreak self-assigned this Jun 26, 2020
ekohl
ekohl approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break a lot of modules so I'm leaning to a 2.0 release. That way we don't break CI for everything until we update in a modulesync. From the Foreman perspective it also won't break all our stable branches.

@bastelfreak bastelfreak added backwards-incompatible and removed enhancement New feature or request labels Jun 27, 2020
@bastelfreak bastelfreak merged commit 4850c66 into voxpupuli:master Jun 27, 2020
@bastelfreak bastelfreak deleted the whitespace branch June 27, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl