puppet-lint: Enable whitespace checker #947
Conversation
|
Hi people, |
|
upstream bug: voxpupuli/puppet-lint-manifest_whitespace-check#4 |
manifests/plugin/apache.pp
Outdated
| @@ -2,11 +2,10 @@ | |||
| class collectd::plugin::apache ( | |||
| Enum['present', 'absent'] $ensure = 'present', | |||
| Boolean $manage_package = $collectd::manage_package, | |||
| Hash $instances = { 'localhost' => { 'url' => 'http://localhost/mod_status?auto' } }, | |||
| Hash $instances = { 'localhost' => { 'url' => 'http://localhost/mod_status?auto' }}, | |||
There was a problem hiding this comment.
Why is this space removed, but not the others?
There was a problem hiding this comment.
This is a bug. It should keep the space.
There was a problem hiding this comment.
As a side note, I had a similar case where I had a default value for a Hash (but more data and thus multiline), which crashed class_parameter-check
manifests/params.pp
Outdated
| @@ -33,12 +32,12 @@ | |||
|
|
|||
| case $facts['kernel'] { | |||
| 'OpenBSD': { $has_wordexp = false } | |||
| default: { $has_wordexp = true } | |||
| default: { $has_wordexp = true } | |||
There was a problem hiding this comment.
It made sense to align the cases before though?
| gem 'voxpupuli-test', '>= 1.4.0', :require => false | ||
| gem 'puppet-lint-manifest_whitespace-check', :require => false |
There was a problem hiding this comment.
I'd prefer to make this a part of vp-test 1.5.0 if it works well (which it appears to do)
There was a problem hiding this comment.
yes, me too. I just added it for testing / enable people to reproduce this.
why extensivly tested this in voxpupuli/puppet-collectd#947
|
Dear @bastelfreak, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
This was included in modulesync 3.0.0 |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues