Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt test to newer rspec-puppet syntax #300

Merged
merged 1 commit into from
Nov 3, 2020
Merged

adopt test to newer rspec-puppet syntax #300

merged 1 commit into from
Nov 3, 2020

Conversation

bastelfreak
Copy link
Member

This came up during #298

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak requested a review from ekohl November 3, 2020 07:07
@bastelfreak bastelfreak self-assigned this Nov 3, 2020
@bastelfreak bastelfreak merged commit 99442a7 into voxpupuli:master Nov 3, 2020
@bastelfreak bastelfreak deleted the tests branch November 3, 2020 10:40
@ekohl
Copy link
Member

ekohl commented Nov 3, 2020

I had hoped you'd fix this one as well:

puppet-splunk/spec/classes/forwarder_spec.rb

Line 43 in 99442a7

it { expect { is_expected.to contain_class('splunk::forwarder') }.to raise_error(Puppet::Error, %r{Do not include splunk::forwarder on the same node as splunk::enterprise}) }

@ekohl
Copy link
Member

ekohl commented Nov 3, 2020

#301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llowder llowder llowder approved these changes

@ekohl ekohl Awaiting requested review from ekohl

Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @llowder