Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rspec 3.10 failures #298

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix rspec 3.10 failures #298

merged 1 commit into from
Nov 3, 2020

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak self-assigned this Nov 2, 2020
ekohl
ekohl approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more things we could clean up, like

puppet-splunk/spec/classes/enterprise_spec.rb

Line 55 in b0e709c

it { expect { is_expected.to contain_class('splunk::enterprise') }.to raise_error(Puppet::Error, %r{Do not include splunk::forwarder on the same node as splunk::enterprise}) }

But I'm fine with just fixing the tests for now.

@bastelfreak bastelfreak merged commit 8a13291 into voxpupuli:master Nov 3, 2020
@bastelfreak bastelfreak deleted the tests branch November 3, 2020 06:58
bastelfreak added a commit to bastelfreak/puppet-splunk that referenced this pull request Nov 3, 2020
@bastelfreak
adopt test to newer rspec-puppet syntax
dad494d 
This came up during voxpupuli#298
@bastelfreak bastelfreak mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl