Use puppetlabs/apache to configure Passenger #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As best I can tell, for Passenger
$version >= 4.0.0 ${gemdir}/buildout/apache2/mod_passenger.so
3.9.0 <= $version < 4.0.0 ${gemdir}/libout/apache2/mod_passenger.so
$version < 3.9.0 ${gemdir}/ext/apache2/mod_passenger.so
This commit also specifies $HOME in execs of rvm commands; not having it
set was breaking on EC2 instances. Finally, I switch to the `osfamily`
fact instead of `operatingsystem` to add compatibility with additional
platforms.
Conflicts: manifests/passenger/apache.pp manifests/passenger/apache/centos/post.pp manifests/passenger/apache/ubuntu/post.pp
Note: this requires huit/puppetlabs-apache@034d018 to be merged upstream before it will work! Clone from huit/puppetlabs-apache mod_libdir_package_params branch.
Note: this requires huit/puppetlabs-apache@034d018 to be merged upstream before it will work! Clone from huit/puppetlabs-apache mod_libdir_package_params branch.
Conflicts: manifests/passenger/apache.pp
Bugfix - forgot to build the Apache module
…into puppetlabs_apache Conflicts: manifests/passenger/apache.pp manifests/passenger/apache/centos/post.pp manifests/passenger/apache/centos/pre.pp manifests/passenger/apache/ubuntu/post.pp manifests/passenger/apache/ubuntu/pre.pp
carlossg
pushed a commit
that referenced
this pull request
Oct 26, 2013
|
I have created a puppetlabs_apache branch with your changes rebased, adding some system tests to verify it all works |
carlossg
pushed a commit
that referenced
this pull request
Nov 6, 2013
[Issue #13] Ensure passenger is not installed on each run
|
added in 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept going with the work that resulted in #11 and ended up replacing the Apache management code in this module with calls to the puppetlabs-apache module. I apologize for the messy commit history.