Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensuring that passenger-install-apache2-module is only called once per gem version #13

Closed
wants to merge 1 commit into from

Conversation

jonoterc
Copy link

fixed output path checked to see if the module has already been generated

…r version (fixed output path tested to see if the module has already been generated)
@carlossg
Copy link
Member

carlossg commented Nov 5, 2013

This wouldn't be needed with the fix in Issue #14 can you check the changes in the puppetlabs_apache branch?

@jonoterc
Copy link
Author

jonoterc commented Nov 5, 2013

I'll try that, thanks...

@jonoterc
Copy link
Author

jonoterc commented Nov 5, 2013

This branch appears to have the same re-installation problem as the maestrodev branch - the $objdir parameter is not being passed in (or is being passed in as an empty string?), so the value passed as the "create" parameter is incorrect.

Asides from the re-installation, there are other issues I worked around:

  • I had to comment out the passenger_lib_path and passenger_manage_package parameters in /manifests/passenger/apache.pp due to "invalid_parameter" errors
  • had to install a Curl development header package (libcurl4-openssl-dev or libcurl4-gnutls-dev)

I should also note that I'm referencing the head of the puppetlabs/apache module (waiting for a package_ensure bug fix to make its way to puppet forge), though I don't see significant breaking changes.

I'm guessing some of these issues are due to differences in the base vagrant boxes that we're referencing - I'm also using Ubuntu 12.04 with the latest puppet, but my box is derived from Puppetlabs' Ubuntu 12.04 for VirtualBox 4.2.10 (at http://puppet-vagrant-boxes.puppetlabs.com), which runs ruby 1.9.3 instead of 1.8.7.

carlossg pushed a commit that referenced this pull request Nov 6, 2013
[Issue #13] Ensure passenger is not installed on each run
@carlossg
Copy link
Member

carlossg commented Nov 6, 2013

Fixed in 1.2.0

@carlossg carlossg closed this Nov 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants