Add datatypes to all params/puppet-strings docs #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ekohl
reviewed
Oct 5, 2020
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
sebastianrakel
approved these changes
Oct 6, 2020
waipeng
added a commit
to waipeng/puppet-puppetboard
that referenced
this pull request
Oct 14, 2020
Running puppetboard without a vhost was not tested, so the changes that we made in voxpupuli#302 were just for puppetboard::apache::vhost, and did not extend to puppetboard::apache::conf Fix up puppetboard::apache::conf the same way, and add a test
waipeng
added a commit
to waipeng/puppet-puppetboard
that referenced
this pull request
Oct 14, 2020
Running puppetboard without a vhost was not tested, so the changes that we made in voxpupuli#302 were just for puppetboard::apache::vhost, and did not extend to puppetboard::apache::conf Fix up puppetboard::apache::conf the same way, and add a test
waipeng
added a commit
to waipeng/puppet-puppetboard
that referenced
this pull request
Oct 14, 2020
Running puppetboard without a vhost was not tested, so the changes that we made in voxpupuli#302 were just for puppetboard::apache::vhost, and did not extend to puppetboard::apache::conf Fix up puppetboard::apache::conf the same way, and add a test
waipeng
added a commit
to waipeng/puppet-puppetboard
that referenced
this pull request
Oct 17, 2020
Running puppetboard without a vhost was not tested, so the changes that we made in voxpupuli#302 were just for puppetboard::apache::vhost, and did not extend to puppetboard::apache::conf Fix up puppetboard::apache::conf the same way, and add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues